Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating secrets #33

Merged
merged 7 commits into from
May 23, 2024
Merged

Creating secrets #33

merged 7 commits into from
May 23, 2024

Conversation

missmesss
Copy link
Contributor

Copied the general procedure from AppStudio docs.
Added a new section "Creating secrets for apps sourced from GitLab".

@missmesss missmesss marked this pull request as draft May 16, 2024 01:32
@github-actions GitHub Actions
Copy link

🚀 Preview is available at

@github-actions GitHub Actions
Copy link

🚀 Preview is available at

@github-actions GitHub Actions
Copy link

🚀 Preview is available at

missmesss
missmesss commented May 17, 2024
View reviewed changes
docs/modules/ROOT/pages/how-tos/configuring/creating-secrets.adoc
* For more information about GitLab access tokens, see link:https://docs.gitlab.com/ee/user/profile/personal_access_tokens.html[Personal access tokens].

* To configure push secrets for your Build and Release pipelines, see link:https://github.com/konflux-ci/konflux-ci?tab=readme-ov-file#configuring-a-push-secret-for-the-build-pipeline[Configuring push secrets] in the Konflux GitHub repository.
Copy link
Contributor Author

@missmesss missmesss May 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check we want to link to a readme.

@github-actions GitHub Actions
Copy link

🚀 Preview is available at

@mshaposhnik @missmesss
Add a example of SCM build secrets
43b465a 
Signed-off-by: Max Shaposhnyk <[email protected]>
(cherry picked from commit b119333)
@github-actions GitHub Actions
Copy link

🚀 Preview is available at

missmesss
missmesss commented May 23, 2024
View reviewed changes
docs/modules/ROOT/pages/how-tos/configuring/creating-secrets.adoc
. Click **Add secret**.

== Creating secrets for GitLab-sourced apps
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshaposhnik Hi, can you please review a procedure that includes your content? It starts on line 28, "Creating secrets for GitLab-sourced apps". Does it all make sense for Konflux?

GitHub isn't mentioned as I was told that only apps created from a GitLab repo will require this special workflow when an access token is added before an app is created. Correct me if this is wrong, please.
Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@missmesss missmesss requested a review from arewm May 23, 2024 01:50
@github-actions GitHub Actions
Copy link

🚀 Preview is available at

@missmesss
Copy link
Contributor Author

missmesss commented May 23, 2024 •
edited
Loading

@arewm Can you please rereview? I hope this is a more or less final version.
I got my answers from Max Shaposhnyk's PR. I guess now this guide has everything we hoped to add to it? Thank you.

@missmesss missmesss marked this pull request as ready for review May 23, 2024 01:53
@mshaposhnik mshaposhnik mentioned this pull request May 23, 2024
Closed
ernesgonzalez33
ernesgonzalez33 requested changes May 23, 2024
View reviewed changes
docs/modules/ROOT/pages/how-tos/configuring/creating-secrets.adoc Outdated
labels:
appstudio.redhat.com/credentials: scm
appstudio.redhat.com/scm.host: <gitlab-host> # eg. gitlab.cee.redhat.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can change the example to gitlab.com instead of our internal instance

arewm
arewm approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments other than those that have already been made.

@github-actions GitHub Actions
Copy link

🚀 Preview is available at

@missmesss
Copy link
Contributor Author

@ernesgonzalez33 Thank you for a review! I've committed your suggested change. I guess we don't want a rereview because of gitlab.com :) I'll merge now.

@missmesss
Copy link
Contributor Author

@ernesgonzalez33 Ah, I just saw your approval, thank you so much!

@missmesss missmesss merged commit 35d1e62 into konflux-ci:main May 23, 2024
2 checks passed
@missmesss missmesss deleted the creating-secrets branch May 23, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernesgonzalez33 ernesgonzalez33 ernesgonzalez33 approved these changes

@arewm arewm arewm approved these changes

@mshaposhnik mshaposhnik mshaposhnik approved these changes

Assignees
No one assigned
Labels
size: L size: XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@missmesss @mshaposhnik @arewm @ernesgonzalez33