fix(Konflux 5917): add an example how user can use a secret in pipeline #208
Conversation
Signed-off-by: Kasem Alem <[email protected]>
This reverts commit adbb34e.
Signed-off-by: Kasem Alem <[email protected]>
kasemAlem
changed the title
|
🚀 Preview is available at https://pr-208--konflux-docs.netlify.app |
| - name: registry-credentials | ||
| secret: | ||
| secretName: registry.redhat.io |
There was a problem hiding this comment.
This is how you use a secret, but what does this secret look like that you are using? Is it clear how values need to match up between the secret and its use?
There was a problem hiding this comment.
+1. I think only one secret name in volumes might not enough as one example.
There was a problem hiding this comment.
I'm confused, maybe I'm missing something
In the current documentation of creating secrets it's detailed step by step how user can create a secret of each type, also there is a good example stated in a note frame :
One such task is the [sast-snyk-check](https://github.com/konflux-ci/build-definitions/tree/main/task/sast-snyk-check) task that uses the third-party service [snyk](https://snyk.io/) to perform static application security testing (SAST) as a part of the default {ProductName} pipeline. Use this procedure to upload your snyk.io token. Name the secret snyk-secret so that the snyk task in the {ProductName} pipeline will recognize it and use it.
It's an example how a third party tool in task requires a specific secret and how it's been used within the task , isn't ?
There was a problem hiding this comment.
Would providing a link to the Creating registry pull secrets section of the guide either above or below this example do the job of clarifying how the secret should look like?
We added a tekton task as an example how user can use the created secrets
within a build or integration pipeline
KONFLUX-5917