docs(RELEASE-1320): update tenant pipeline example pipelineRef #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Preview is available at https://pr-207--konflux-docs.netlify.app |
|
@arewm PTAL |
arewm
reviewed
Jan 15, 2025
docs/modules/ROOT/pages/advanced-how-tos/releasing/tenant-release-pipelines.adoc
Outdated
Show resolved
Hide resolved
The pipelineRef in the tenant pipeline never really made much sense. It suggested using a managed pipeline, which would not work (and many users made this mistake). This updates the example to something that should be more obviously an example and not a real pipeline. We also moved the pipeline definitions in release-service-catalog, so the old reference won't even exist going forward. That is another reason to change it. If a working tenant pipeline is created, we can update the docs to use that as the example. Signed-off-by: Johnny Bieren <[email protected]>
johnbieren
force-pushed
the
release1320
branch
from
a2270b7 to
934a683
Compare
|
🚀 Preview is available at https://pr-207--konflux-docs.netlify.app |
arewm
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pipelineRef in the tenant pipeline never really made much sense. It suggested using a managed pipeline, which would not work (and many users made this mistake). This updates the example to something that should be more obviously an example and not a real pipeline.
We also moved the pipeline definitions in release-service-catalog, so the old reference won't even exist going forward. That is another reason to change it.
If a working tenant pipeline is created, we can update the docs to use that as the example.