doc: custom timeout annotations for integration tests #188
Conversation
|
🚀 Preview is available at https://pr-188--konflux-docs.netlify.app |
dirgim
force-pushed
the
KFLUXBUGS-1889-1
branch
from
834dcce to
e6ba014
Compare
|
🚀 Preview is available at https://pr-188--konflux-docs.netlify.app |
dirgim
requested review from
arewm,
14rcole,
Josh-Everett,
hongweiliu17,
kasemAlem,
dheerajodha,
sonam1412,
jsztuka and
jencull
There was a problem hiding this comment.
looks good to me.
Nit: should we include information on this in editing too? Or put this information there and cross ref it from creating? The action to take feels like more of an editing action since it is specified as a CLI-based annotation added to the ITS.
Look good to me. I have the same thought. Can we also permit users to edit integragtionTestScenario and set the annotation for the timeouts. |
dirgim
force-pushed
the
KFLUXBUGS-1889-1
branch
from
e6ba014 to
6f0ca25
Compare
|
🚀 Preview is available at https://pr-188--konflux-docs.netlify.app |
|
@arewm @hongweiliu17 ack, good points, I updated the PR to have the instrunctions as part of the editing doc and cross-referenced it in the custom test creation. |
* It is possible to set custom pipeline timeouts via annotations Signed-off-by: dirgim <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
dirgim
force-pushed
the
KFLUXBUGS-1889-1
branch
from
6f0ca25 to
f9b8c2b
Compare
|
🚀 Preview is available at https://pr-188--konflux-docs.netlify.app |
Signed-off-by: dirgim [email protected]