Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed changes related to #36: Accordion style layout of composite resources #67

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

etesami
Copy link
Contributor

@etesami etesami commented Aug 23, 2024

Related to issue #36, this PR proposes a new accordion-style layout for composite resource lists. This layout provides a categorized view of objects based on their API version, which is more effective and visually appealing for handling large numbers of objects.

Additionally, this style includes labels for a quick overview of resource status. It displays counts of resources in various states (e.g., Ready, Not Ready, Synced) for each group, making it easier to gauge the status at a glance. A screenshot of this style is provided below:

Screenshot 2024-08-23 at 2 21 28 PM

Similar changes can be applied to the Claims and Managed Resources pages.

@etesami etesami changed the title Proposed changed related to #36: Accordion style layout of composite resources Proposed changes related to #36: Accordion style layout of composite resources Aug 23, 2024
Copy link
Collaborator

@undera undera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the linter complains

@etesami etesami requested a review from undera August 25, 2024 23:45
@undera
Copy link
Collaborator

undera commented Aug 26, 2024

Many thanks for contributing!

@undera undera merged commit 2b804b3 into komodorio:main Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants