Report that an internet connection is available potentially sooner when one of the addresses is unreachable #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report that an internet connection is available as soon as one request succeeds instead of potentially waiting for the last to time out.
spkersten
changed the title
|
Waiting for multiple responses makes sense if one of test servers is down or unavailable for given user (e.g. locked in the country) |
|
@PiN73 If one server is down or locked, you wouldn't want to wait for that connection request to time out before reporting that there is an internet connection (which you know because another server already responded). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report that an internet connection is available as soon as one request succeeds instead of potentially waiting for the last to time out.