misc: update golangci-lint and use cached action #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thor
force-pushed
the
misc/update-golangci-lint
branch
from
6a74ba8 to
db6b7a2
Compare
|
Do you want to merge the other PR as-is, @hanssto, and then we can rebase and merge this one? It looks like it'd be nice to have the full history for these smaller changes. |
|
I'm torn between "I shouldn't spend more time on this" and "I should rework the other PR so that it's more sane in the event of us ever merging this back upstream". I will let tomorrow-me decide as I have to pick up the spawn. |
My suggestion is, @hanssto:
Au voila. |
hanssto
added a commit
that referenced
this pull request
Oct 4, 2024
We have a critical security update on Docker auth, which is an indirect dependency of the test code (seemingly via oras). This is the culmination of different attempts at upgrading without having to make substantial changes to the sloth source code. Some notes: * Upgrading go-helm-template (also made by slok) in test ultimately requires at least Go 1.22. * The GH actions uses the root go.mod Go version, so these need to be synced. * The next version of reloader, also made by slok, requires 1.23, so both root and test needs to be on 1.23. * Updated the dev and prod Dockerfiles to match the go version. * Upgraded most dependencies to get as far as possible. * Keeping Prometheus-related deps as certain newer versions don't work with the code. There might be further version jumps we can do here. This results in errors on lint which are addressed in #35.
hanssto
force-pushed
the
hanst/upgrade-various-deps
branch
from
e1c5f6e to
776c994
Compare
hanssto
added a commit
that referenced
this pull request
Oct 4, 2024
We have a critical security update on Docker auth, which is an indirect dependency of the test code (seemingly via oras). This is the culmination of different attempts at upgrading without having to make substantial changes to the sloth source code. Some notes: * Upgrading go-helm-template (also made by slok) in test ultimately requires at least Go 1.22. * The GH actions uses the root go.mod Go version, so these need to be synced. * The next version of reloader, also made by slok, requires 1.23, so both root and test needs to be on 1.23. * Updated the dev and prod Dockerfiles to match the go version. * Upgraded most dependencies to get as far as possible. * Keeping Prometheus-related deps as certain newer versions don't work with the code. There might be further version jumps we can do here. This results in errors on lint which are addressed in #35.
Default configuration has no rules for depguard, let's not enable it when it doesn't help us.
hanssto
force-pushed
the
misc/update-golangci-lint
branch
from
21ce7a8 to
fba8e97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable depguard as it's unconfigured and ignore the noop logger for unused parameters.