Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 23.11 #17

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Upgrade to 23.11 #17

merged 2 commits into from
Jan 19, 2024

Conversation

RebeccaMahany
Copy link
Contributor

23.05 is EOL as of Dec 2023, so it's time for an upgrade.

@RebeccaMahany RebeccaMahany marked this pull request as ready for review January 19, 2024 15:28
url = "https://github.com/nixOS/nixpkgs/archive/23.05.tar.gz";
sha256 = "sha256:10wn0l08j9lgqcw8177nh2ljrnxdrpri7bp0g7nvrsn9rkawvlbf";
url = "https://github.com/nixOS/nixpkgs/archive/23.11.tar.gz";
sha256 = "sha256-uQvEhiv33Zj/Pv364dTvnpPwFSptRZgVedDzoM+HqVg=";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you intend to change from sha256:... to sha256-...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh blah, I was copy-pasting from the flake because the CI job wasn't giving me the updated SHA like I wanted it to. Let me fix this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it looks like the correct way is to do this with a fetchTarball is to run nix-prefetch-url --unpack https://github.com/nixOS/nixpkgs/archive/23.11.tar.gz (need the --unpack because fetchTarball will perform the unpacking before hashing). 🤞 I've updated, hopefully it's correct.

@RebeccaMahany RebeccaMahany merged commit 5e645bb into main Jan 19, 2024
1 check passed
@RebeccaMahany RebeccaMahany deleted the becca/nixos-2311 branch January 19, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants