Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder presence detection write headers to remove warnings #2024

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

zackattack01
Copy link
Contributor

noticed these logs while debugging:

"msg":"2025/01/03 10:24:42 http: superfluous response.WriteHeader call from github.com/kolide/launcher/ee/desktop/user/server.(*UserServer).detectPresence (server.go:234)","component":"desktop_runner"

reading the docs this happens when WriteHeader is called multiple times, or after Write is called. this is harmless in our current invocation because http package will write a default OK status, but ordering these correctly should remove the warnings

@zackattack01 zackattack01 added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit 7eff9a5 Jan 3, 2025
33 checks passed
@zackattack01 zackattack01 deleted the zack/fix_superflous_write_header branch January 3, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants