Don't flag errors related to running flare as standalone #2011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of our checkups can't run if the flare is running standalone because they can't access bboltdb -- a) the server data checkup and b) the bboltdb checkup. In these cases, we are currently including a fairly alarming error message and flagging as either erroring or warning. The server data checkup reports a warning emoji plus
Server Data: no server_data store in knapsack
, and the bboltdb checkup reports an erroring emoji plusbboltdb: failed to run: no DB available
. When someone is not familiar with how flares work, this will be unnecessarily concerning to them.This PR updates these two checkups to return an informational status if the database connection isn't available, and adjusts the language in the summary to be less concerning. (The server data checkup will now report
Server Data: server_data not available
without an emoji, and the bbolt checkup will now reportbboltdb: N/A
without an emoji.)In the future, I think we may want to pass through whether the checkup is running in situ or standalone to the
Run
function so that we can adjust behavior accordingly -- but I didn't think it was worth it at this time.