Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't flag errors related to running flare as standalone #2011

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Dec 19, 2024

A couple of our checkups can't run if the flare is running standalone because they can't access bboltdb -- a) the server data checkup and b) the bboltdb checkup. In these cases, we are currently including a fairly alarming error message and flagging as either erroring or warning. The server data checkup reports a warning emoji plus Server Data: no server_data store in knapsack, and the bboltdb checkup reports an erroring emoji plus bboltdb: failed to run: no DB available. When someone is not familiar with how flares work, this will be unnecessarily concerning to them.

This PR updates these two checkups to return an informational status if the database connection isn't available, and adjusts the language in the summary to be less concerning. (The server data checkup will now report Server Data: server_data not available without an emoji, and the bbolt checkup will now report bboltdb: N/A without an emoji.)

In the future, I think we may want to pass through whether the checkup is running in situ or standalone to the Run function so that we can adjust behavior accordingly -- but I didn't think it was worth it at this time.

@RebeccaMahany RebeccaMahany added the features-improvements Features and Improvements label Dec 19, 2024
@RebeccaMahany RebeccaMahany added this pull request to the merge queue Dec 19, 2024
Merged via the queue into kolide:main with commit fa6e3ac Dec 19, 2024
32 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/standalone-messaging branch December 19, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features-improvements Features and Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants