Perform presence detection on Windows using UserConsentVerifier interop #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desktop triggers Windows Hello Fix timeout, small refactor Tidy up names, add documentation Retrieve key credential status Retrieve pubkey Get attestation Proof-of-concept for Windows Hello
James-Pickett
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1865 with a more appropriate implementation for our usecase.
This PR uses UserConsentVerifier.RequestVerificationAsync to perform presence detection. Because we are not a UWP app, we have to call this method by way of the interop interface --
IUserConsentVerifierInterop.RequestVerificationForWindowAsync.Calling
RequestVerificationForWindowAsyncrequires a reference to a window, which we already have via systray, so I exposed that window in systray for use here.I pulled in
winrt-gobecause it makes it significantly easier to call async functions.