Take and use backups of the launcher database #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RebeccaMahany
commented
Jun 14, 2024
•
RebeccaMahany
commented
- launcher takes periodic backups of its own database, beginning 10 mins after startup
- bbolt checkup includes stats about the backup database
- If its original database is unavailable but a backup is, launcher uses that backup db
- On remote uninstall, the backup database is deleted
RebeccaMahany
changed the title
| return filepath.Join(rootDir, "launcher.db") | ||
| } | ||
|
|
||
| func BackupLauncherDbLocation(rootDir string) string { |
There was a problem hiding this comment.
I hate to say this, but we probably need to keep N and rotate. Otherwise we can probably get inconsistency if there's a reader and writer. :|
There was a problem hiding this comment.
I wasn't super worried about that because of how the access remains relatively restricted in this implementation --
- On launcher startup, before any rungroups execute, launcher may rename
launcher.db.baktolauncher.db; nothing else is accessing either db at this time - After rungroups begin to execute, this actor is the only thing touching
launcher.db.bak-- nothing else will read from it or write to it - (Except for the flare checkup -- and data inconsistency probably isn't a huge deal there, and I'm not sure how much we even care about having that checkup anyway)
- (There's also remote uninstall, but that just wants to delete the file)
Is there something I'm missing?
I'm happy to keep N and rotate if we feel like that's a safer option, regardless.
There was a problem hiding this comment.
I added rotation in 15183fa -- lmk what you're thinking!
zackattack01
previously approved these changes
Jun 18, 2024
zackattack01
previously approved these changes
Jun 18, 2024
directionless
previously approved these changes
Jun 18, 2024
RebeccaMahany
dismissed stale reviews from directionless and zackattack01
via
e75bd61
RebeccaMahany
force-pushed
the
becca/db-bak
branch
from
822af61 to
e75bd61
Compare
directionless
previously approved these changes
Jun 18, 2024
zackattack01
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.