Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More staticcheck + lint updates #1574

Merged
merged 12 commits into from
Feb 1, 2024
Merged

More staticcheck + lint updates #1574

merged 12 commits into from
Feb 1, 2024

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Feb 1, 2024 •
edited
Loading

  • Fix some more lint errors
  • Remove deprecated linters from our golangci-lint linters
  • Enable staticcheck linter in golangci-lint
  • Enable ineffassign

@RebeccaMahany RebeccaMahany marked this pull request as ready for review February 1, 2024 21:29
zackattack01
zackattack01 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@zackattack01 zackattack01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@RebeccaMahany RebeccaMahany added this pull request to the merge queue Feb 1, 2024
Merged via the queue into kolide:main with commit 4704d18 Feb 1, 2024
28 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/staticcheck-2 branch February 1, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackattack01 zackattack01 zackattack01 approved these changes

@James-Pickett James-Pickett James-Pickett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RebeccaMahany @James-Pickett @zackattack01