Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use knapsack to set watchdog values; restart osquery on watchdog flag changes #1506

Merged

Conversation

RebeccaMahany
Copy link
Contributor

Relates to #1224

Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty solid

pkg/osquery/runtime/osqueryinstance.go Show resolved Hide resolved
@RebeccaMahany RebeccaMahany force-pushed the becca/apply-osq-watchdog-opts branch from 7ad1028 to f6102b3 Compare December 12, 2023 15:42
@RebeccaMahany RebeccaMahany marked this pull request as ready for review December 12, 2023 16:18
Copy link
Contributor

@James-Pickett James-Pickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

@zackattack01 zackattack01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@RebeccaMahany RebeccaMahany reopened this Dec 12, 2023
@RebeccaMahany RebeccaMahany added this pull request to the merge queue Dec 12, 2023
Merged via the queue into kolide:main with commit e4dec2f Dec 12, 2023
24 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/apply-osq-watchdog-opts branch December 12, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants