Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure localserver's runAsyncdWorkers shuts down on rungroup shutdown #1493

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Ensure localserver's runAsyncdWorkers shuts down on rungroup shutdown #1493

merged 2 commits into from
Dec 5, 2023

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Dec 5, 2023 •
edited
Loading

Cleans up goroutine on rungroup shutdown.

@RebeccaMahany RebeccaMahany marked this pull request as ready for review December 5, 2023 21:18
directionless
directionless approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm game. I think embedding ctx is an anti-pattern, but I'm hard pressed to think of a simpler one just now

@RebeccaMahany RebeccaMahany added this pull request to the merge queue Dec 5, 2023
Merged via the queue into kolide:main with commit e9b4b36 Dec 5, 2023
25 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/localserver-shutdown branch December 5, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackattack01 zackattack01 zackattack01 approved these changes

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RebeccaMahany @directionless @zackattack01