Include logs in test failure when TUF autoupdater doesn't shut down/restart within 5 seconds #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r restart within 5 seconds
directionless
approved these changes
Nov 13, 2023
| @@ -116,7 +116,7 @@ func TestExecute_launcherUpdate(t *testing.T) { | |||
| shutdownDeadline := time.Now().Add(5 * time.Second).Unix() | |||
| for { | |||
| if time.Now().Unix() > shutdownDeadline { | |||
| t.Error("autoupdater did not shut down within 5 seconds") | |||
| t.Error("autoupdater did not shut down within 5 seconds -- logs: ", logBytes.String()) | |||
There was a problem hiding this comment.
I wonder if this is going to be readable, or kind of a mess. I wonder about just copying it to os.Stderr
There was a problem hiding this comment.
It'll definitely be a little messy, but it's hopefully not permanent! I don't think we'd see output if we copy to os.Stderr -- I find that output from tests tends to get swallowed in CI, and if I write something to os.Stderr in a test I don't see that output when running make test locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen this test failure fairly frequently: https://github.com/kolide/launcher/actions/runs/6852148852/job/18630008978
Not sure why it's happening -- it doesn't happen locally -- so I'm including the autoupdater logs in the test failure message in order to figure it out.