Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds device id values to slog shipping #1447

Merged
merged 2 commits into from
Nov 8, 2023
Merged

adds device id values to slog shipping #1447

merged 2 commits into from
Nov 8, 2023

Conversation

James-Pickett
Copy link
Contributor

No description provided.

@James-Pickett James-Pickett marked this pull request as ready for review November 8, 2023 17:17
zackattack01
zackattack01 previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@zackattack01 zackattack01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 💯

@James-Pickett James-Pickett added this pull request to the merge queue Nov 8, 2023
Merged via the queue into kolide:main with commit d5cca90 Nov 8, 2023
26 checks passed
@James-Pickett James-Pickett deleted the james/logshipper-slogger-identifying-values branch November 8, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackattack01 zackattack01 zackattack01 approved these changes

@RebeccaMahany RebeccaMahany RebeccaMahany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@James-Pickett @RebeccaMahany @zackattack01