Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore duplicate libraries warning during build #1423

Closed
wants to merge 1 commit into from
Closed

Ignore duplicate libraries warning during build #1423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/make/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,12 @@ func (b *Builder) BuildCmd(src, appName string) func(context.Context) error {
}

if stderr.Len() > 0 {
return errors.New("stderr not empty")
// We know this warning is safe to ignore and we expect that it should go away
// with a future Golang version.
if strings.TrimSpace(stderr.String()) != fmt.Sprintf(`# github.com/kolide/launcher/cmd/%s
ld: warning: ignoring duplicate libraries: '-lobjc'`, filepath.Base(src)) {
return errors.New("stderr not empty")
}
}

// Tell github where we're at
Expand Down
Loading