Export traces less frequently #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directionless
previously approved these changes
Oct 25, 2023
James-Pickett
previously approved these changes
Oct 25, 2023
RebeccaMahany
dismissed stale reviews from James-Pickett and directionless
via
6a4c308
I've updated so it's a control server flag! |
RebeccaMahany
force-pushed
the
becca/trace-batch-timeout
branch
from
6a4c308 to
ef8e404
Compare
directionless
previously approved these changes
Oct 27, 2023
directionless
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exporter already has a maximum batch size and maximum queue size configured, but we were never hitting the maximum batch size because the batch timeout is set very low by default, enforcing shipping batches every 5 seconds. This probably isn't necessary for our usecase, so I've increased the batch timeout to a minute.