[Flare] Update a couple things in how flares are shipped #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
previously approved these changes
Oct 23, 2023
directionless
changed the title
directionless
force-pushed
the
seph/flare-tweaks
branch
from
b22c3ad to
cb44332
Compare
cmd/launcher/flare.go
Outdated
| flagset = flag.NewFlagSet("flare", flag.ExitOnError) | ||
| flSave = flagset.String("save", "upload", "local | upload") | ||
| flOutputDir = flagset.String("output_dir", ".", "path to directory to save flare output") | ||
| flUploadRequestURL = flagset.String("upload_request_url", "", "URL to request a signed upload URL") |
There was a problem hiding this comment.
should we populate this with the default URL or do we want to send down from control server? But sending from control server would mean that a non-enrolled launcher would still need this as a cmd line flag.
There was a problem hiding this comment.
Oh! I hadn't even realized it didn't default to something. Yeah, let me update that. Thank you
RebeccaMahany
previously approved these changes
Oct 30, 2023
zackattack01
previously approved these changes
Oct 30, 2023
directionless
dismissed stale reviews from zackattack01 and RebeccaMahany
via
bb11234
James-Pickett
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the SaaS side supports flare shipping, I've found a couple of issues, and tweaks:
Content-Typeheader. Otherwise rails won't parse the data and we don't get the extra stuff.I considered, but did not, adjust flare to also print doctor output. I'm on the fence about output in general. So it's still TBD