Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TUF] If a downgrade occurs, restart the given binary #1411

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Oct 17, 2023

As I started to look at automated tests for autoupdate, I noticed that if the release version for a binary switches to a version already in the local library, the binary won't be restarted to run the appropriate version. This PR corrects that oversight, ensuring that we don't perform unnecessary restarts when running dev builds.

@RebeccaMahany RebeccaMahany changed the title If a downgrade occurs, restart the given binary [TUF] If a downgrade occurs, restart the given binary Oct 17, 2023
@RebeccaMahany RebeccaMahany marked this pull request as draft October 17, 2023 21:21
@RebeccaMahany RebeccaMahany marked this pull request as ready for review October 18, 2023 13:25
Copy link
Contributor

@zackattack01 zackattack01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@RebeccaMahany RebeccaMahany added this pull request to the merge queue Oct 18, 2023
Merged via the queue into kolide:main with commit 1ac7d3e Oct 18, 2023
24 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/tuf-downgrade-apply branch October 18, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants