Bump the otel version #1405
Closed
Bump the otel version #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,5 +11,5 @@ For additional documentation on the topic: | |||
| package tools | |||
|
|
|||
| import ( | |||
| _ "github.com/go-bindata/go-bindata/go-bindata/" | |||
| _ "github.com/go-bindata/go-bindata/go-bindata" | |||
There was a problem hiding this comment.
When I make this change locally, make deps fails for me, which I think is also breaking the pipeline build -- I think this started after the upgrade to 1.21. (I've been removing this slash every time I run go mod tidy and then adding it back so that make -j2 github-build doesn't fail for me, which is...an annoying workflow.)
There was a problem hiding this comment.
Hrm. yes. Okay. Maybe it's time to retire the go form, and just put it in make
There was a problem hiding this comment.
You know... It might be fine to drop this from go.mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1403
Bump otel, as dependabot noticed in #1403
And fix the import statement that was breaking
go mod tidy