Allow actor Interrupt functions to be called multiple times without blocking #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
force-pushed
the
becca/rungroup-interrupt-multiple-again
branch
from
6cdd3f0 to
9d658e9
Compare
…e small change to run function to avoid data race in test
…rrupt-multiple-again
…rrupt-multiple-again
RebeccaMahany
commented
Oct 12, 2023
…rrupt-multiple-again
directionless
previously approved these changes
Oct 13, 2023
directionless
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates remaining actors'
Interruptfunctions to ensure all are safe to be called multiple times without blocking. Ensures all actors have tests verifying same.Fixes issue where trace exporter could leave a goroutine running without being able to interrupt it if launcher shuts down within the first 3 minutes.