SA4023 staticcheck fixes (#1604)

kolide · Feb 14, 2024 · edbb083 · edbb083
1 parent a0eb0b9
commit edbb083
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/ee/desktop/runner/runner.go b/ee/desktop/runner/runner.go
@@ -194,14 +194,13 @@ func New(k types.Knapsack, messenger runnerserver.Messenger, opts ...desktopUser
 	}()
 
 	if runtime.GOOS == "darwin" {
-		osversion, err := osversion()
+		runner.osVersion, err = osversion()
 		if err != nil {
 			runner.slogger.Log(context.TODO(), slog.LevelError,
 				"getting os version",
 				"err", err,
 			)
 		}
-		runner.osVersion = osversion
 	}
 
 	setInstance(runner)
@@ -880,7 +879,7 @@ func (r *DesktopUsersProcessesRunner) checkOsUpdate() {
 		return
 	}
 
-	osVersion, err := osversion()
+	currentOsVersion, err := osversion()
 	if err != nil {
 		r.slogger.Log(context.TODO(), slog.LevelError,
 			"getting os version",
@@ -889,13 +888,13 @@ func (r *DesktopUsersProcessesRunner) checkOsUpdate() {
 		return
 	}
 
-	if osVersion != r.osVersion {
+	if currentOsVersion != r.osVersion {
 		r.slogger.Log(context.TODO(), slog.LevelInfo,
 			"os version changed, restarting desktop",
 			"old", r.osVersion,
-			"new", osVersion,
+			"new", currentOsVersion,
 		)
-		r.osVersion = osVersion
+		r.osVersion = currentOsVersion
 		r.killDesktopProcesses()
 	}
 }