Skip to content

Commit

Permalink
Add circle-dot icon (#1547)
Browse files Browse the repository at this point in the history
  • Loading branch information
RebeccaMahany authored Jan 12, 2024
1 parent 65eb6b9 commit af3a7aa
Show file tree
Hide file tree
Showing 16 changed files with 40 additions and 0 deletions.
1 change: 1 addition & 0 deletions ee/desktop/user/menu/menu.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ const (
DefaultIcon menuIcon = "default"
TriangleExclamationIcon menuIcon = "triangle-exclamation"
CircleXIcon menuIcon = "circle-x"
CircleDotIcon menuIcon = "circle-dot"
)

// MenuData encapsulates a menu bar icon and accessible menu items
Expand Down
11 changes: 11 additions & 0 deletions ee/desktop/user/menu/menu_icon.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,17 @@ func getIcon(icon menuIcon) []byte {
assets.MenubarCircleXMonochromeIco,
assets.MenubarCircleXMonochromePng,
)
case CircleDotIcon:
return chooseIcon(
assets.MenubarCircleDotDarkmodeIco,
assets.MenubarCircleDotDarkmodePng,
assets.MenubarCircleDotLightmodeIco,
assets.MenubarCircleDotLightmodePng,
assets.MenubarCircleDotLightmodeShadowIco,
assets.MenubarCircleDotLightmodeShadowPng,
assets.MenubarCircleDotMonochromeIco,
assets.MenubarCircleDotMonochromePng,
)
default:
return nil
}
Expand Down
4 changes: 4 additions & 0 deletions ee/desktop/user/menu/menu_icon_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ func Test_getIcon(t *testing.T) {
name: "CircleX",
icon: CircleXIcon,
},
{
name: "CircleDot",
icon: CircleDotIcon,
},
}
for _, tt := range tests {
tt := tt
Expand Down
24 changes: 24 additions & 0 deletions ee/ui/assets/assets.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,30 @@ var KolideIco []byte
//go:embed kolide.png
var KolidePng []byte

//go:embed menubar-circle-dot-darkmode.ico
var MenubarCircleDotDarkmodeIco []byte

//go:embed menubar-circle-dot-darkmode.png
var MenubarCircleDotDarkmodePng []byte

//go:embed menubar-circle-dot-lightmode.ico
var MenubarCircleDotLightmodeIco []byte

//go:embed menubar-circle-dot-lightmode.png
var MenubarCircleDotLightmodePng []byte

//go:embed menubar-circle-dot-lightmode-shadow.ico
var MenubarCircleDotLightmodeShadowIco []byte

//go:embed menubar-circle-dot-lightmode-shadow.png
var MenubarCircleDotLightmodeShadowPng []byte

//go:embed menubar-circle-dot-monochrome.ico
var MenubarCircleDotMonochromeIco []byte

//go:embed menubar-circle-dot-monochrome.png
var MenubarCircleDotMonochromePng []byte

//go:embed menubar-circle-x-darkmode.ico
var MenubarCircleXDarkmodeIco []byte

Expand Down
Binary file added ee/ui/assets/menubar-circle-dot-darkmode.ico
Binary file not shown.
Binary file added ee/ui/assets/menubar-circle-dot-darkmode.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ee/ui/assets/menubar-circle-dot-lightmode.ico
Binary file not shown.
Binary file added ee/ui/assets/menubar-circle-dot-lightmode.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ee/ui/assets/menubar-circle-dot-monochrome.ico
Binary file not shown.
Binary file added ee/ui/assets/menubar-circle-dot-monochrome.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit af3a7aa

Please sign in to comment.