Rename Platform to Filter

kolide · Jul 3, 2024 · 5fa2de9 · 5fa2de9
1 parent b3f251c
commit 5fa2de9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/ee/katc/config.go b/ee/katc/config.go
@@ -92,7 +92,7 @@ func (r *rowTransformStep) UnmarshalJSON(data []byte) error {
 type katcTableConfig struct {
 	SourceType        katcSourceType     `json:"source_type"`
 	SourcePaths       []string           `json:"source_paths"` // Describes how to connect to source (e.g. path to db) -- % and _ wildcards supported
-	Platform          string             `json:"platform"`
+	Filter            string             `json:"filter"`
 	Columns           []string           `json:"columns"`
 	SourceQuery       string             `json:"source_query"` // Query to run against each source path
 	RowTransformSteps []rowTransformStep `json:"row_transform_steps"`
@@ -113,7 +113,8 @@ func ConstructKATCTables(config map[string]string, slogger *slog.Logger) []osque
 			continue
 		}
 
-		if cfg.Platform != runtime.GOOS {
+		// For now, the filter is simply the OS
+		if cfg.Filter != runtime.GOOS {
 			continue
 		}
 

diff --git a/ee/katc/config_test.go b/ee/katc/config_test.go
@@ -23,7 +23,7 @@ func TestConstructKATCTables(t *testing.T) {
 			katcConfig: map[string]string{
 				"kolide_snappy_sqlite_test": fmt.Sprintf(`{
 					"source_type": "sqlite",
-					"platform": "%s",
+					"filter": "%s",
 					"columns": ["data"],
 					"source_paths": ["/some/path/to/db.sqlite"],
 					"source_query": "SELECT data FROM object_data JOIN object_store ON (object_data.object_store_id = object_store.id) WHERE object_store.name=\"testtable\";",
@@ -37,15 +37,15 @@ func TestConstructKATCTables(t *testing.T) {
 			katcConfig: map[string]string{
 				"test_1": fmt.Sprintf(`{
 					"source_type": "sqlite",
-					"platform": "%s",
+					"filter": "%s",
 					"columns": ["data"],
 					"source_paths": ["/some/path/to/db.sqlite"],
 					"source_query": "SELECT data FROM object_data;",
 					"row_transform_steps": ["snappy"]
 				}`, runtime.GOOS),
 				"test_2": fmt.Sprintf(`{
 					"source_type": "sqlite",
-					"platform": "%s",
+					"filter": "%s",
 					"columns": ["col1", "col2"],
 					"source_paths": ["/some/path/to/a/different/db.sqlite"],
 					"source_query": "SELECT col1, col2 FROM some_table;",
@@ -66,7 +66,7 @@ func TestConstructKATCTables(t *testing.T) {
 			katcConfig: map[string]string{
 				"kolide_snappy_test": fmt.Sprintf(`{
 					"source_type": "unknown_source",
-					"platform": "%s",
+					"filter": "%s",
 					"columns": ["data"],
 					"source_paths": ["/some/path/to/db.sqlite"],
 					"source_query": "SELECT data FROM object_data;"
@@ -79,7 +79,7 @@ func TestConstructKATCTables(t *testing.T) {
 			katcConfig: map[string]string{
 				"kolide_snappy_test": fmt.Sprintf(`{
 					"source_type": "sqlite",
-					"platform": "%s",
+					"filter": "%s",
 					"columns": ["data"],
 					"source_paths": ["/some/path/to/db.sqlite"],
 					"source_query": "SELECT data FROM object_data;",

diff --git a/ee/katc/table_test.go b/ee/katc/table_test.go
@@ -86,7 +86,7 @@ func Test_generate_SqliteBackedIndexedDB(t *testing.T) {
 			name:     sqliteSourceType,
 			dataFunc: sqliteData,
 		},
-		Platform:    runtime.GOOS,
+		Filter:      runtime.GOOS,
 		Columns:     []string{expectedColumn},
 		SourcePaths: []string{filepath.Join(databaseDir, "%.sqlite")}, // All sqlite files in the test directory
 		SourceQuery: "SELECT data FROM object_data;",