embed flags into knapsack

kolide · Feb 1, 2024 · 59430bb · 59430bb
1 parent 91e7a9a
commit 59430bb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 366 deletions.
diff --git a/ee/agent/flags/keys/keys.go b/ee/agent/flags/keys/keys.go
@@ -6,8 +6,7 @@ type FlagKey string
 // When adding a new FlagKey:
 // 1. Define the FlagKey identifier, and the string key value it corresponds to, in the block below
 // 2. Add a getter and setter to the Flags interface (flags.go)
-// 3. Implement the getter and setter in the Knapsack, which delegates the call to the FlagController
-// 4. Implement the getter and setter in the FlagController, providing defaults, limits, and overrides
+// 3. Implement the getter and setter in the FlagController, providing defaults, limits, and overrides
 // 4. Implement tests for any new APIs, sanitizers, limits, overrides.
 // 5. Update mocks -- in ee/agent/types, run `mockery --name Knapsack` and `mockery --name Flags`.
 const (