PR review: move docs to docs/architecture, add clarifying comments, m…

…ore readable const

ee/watchdog/README.md → docs/architecture/launcher_watchdog.md

@@ -1,5 +1,8 @@
 ### Watchdog Service
 
+Note that for the initial implementation, this service is windows only. It is intentionally designed to give room for alternate OS implementations if needed in the future.
+Most of the relevant code can be found in [ee/watchdog](../../ee/watchdog/)
+
 Here is a basic sequence diagram displaying the enable path for the windows watchdog service. The `launcher_watchdog_enabled` control flag will trigger the initial configuration and installation, and removal of the flag will trigger removal of the service.
 
 ```mermaid

ee/watchdog/controller_windows.go

@@ -26,7 +26,7 @@ const (
 
 	serviceDoesNotExistError string = "The specified service does not exist as an installed service."
 
-	serviceResetPeriod uint32 = 10800 // 3 hours in seconds
+	serviceResetPeriodSeconds uint32 = 3 * 60 * 60 // 3 hours in seconds
 )
 
 // WatchdogController is responsible for:
@@ -87,7 +87,9 @@ func (wc *WatchdogController) Run() error {
 }
 
 func (wc *WatchdogController) publishLogs(ctx context.Context) {
-	// do nothing if watchdog is not enabled
+	// note that there is a small window here where there could be pending logs before watchdog is disabled -
+	// there is no harm in leaving them and we could recover these with the original timestamps if we ever needed.
+	// to avoid endlessly re-processing empty logs while we are disabled, we accept this possibility and exit early here
 	if !wc.knapsack.LauncherWatchdogEnabled() {
 		return
 	}
@@ -264,7 +266,7 @@ func (wc *WatchdogController) installService(serviceManager *mgr.Mgr) error {
 		},
 	}
 
-	if err = restartService.SetRecoveryActions(recoveryActions, serviceResetPeriod); err != nil {
+	if err = restartService.SetRecoveryActions(recoveryActions, serviceResetPeriodSeconds); err != nil {
 		wc.slogger.Log(ctx, slog.LevelWarn,
 			"unable to set recovery actions for service installation, proceeding",
 			"err", err,