Update comments for clarity

kolide · Jul 15, 2024 · 4b9b56b · 4b9b56b
1 parent 70ec1c9
commit 4b9b56b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/ee/katc/indexeddb_leveldb.go b/ee/katc/indexeddb_leveldb.go
@@ -35,7 +35,9 @@ func indexeddbLeveldbData(ctx context.Context, slogger *slog.Logger, sourcePaths
 
 		// Query databases
 		for _, db := range leveldbs {
-			// Check to make sure `db` adheres to pathConstraintsFromQuery
+			// Check to make sure `db` adheres to pathConstraintsFromQuery. This is an
+			// optimization to avoid work -- no point in querying a leveldb file that a filter
+			// will exclude anyway.
 			valid, err := checkPathConstraints(db, pathConstraintsFromQuery)
 			if err != nil {
 				return nil, fmt.Errorf("checking source path constraints: %w", err)

diff --git a/ee/katc/sqlite.go b/ee/katc/sqlite.go
@@ -26,7 +26,8 @@ func sqliteData(ctx context.Context, slogger *slog.Logger, sourcePaths []string,
 		}
 
 		for _, sqliteDb := range sqliteDbs {
-			// Check to make sure `sqliteDb` adheres to pathConstraintsFromQuery
+			// Check to make sure `db` adheres to pathConstraintsFromQuery. This is an
+			// optimization to avoid work, if sqlite filtering is going to exclude it.
 			valid, err := checkPathConstraints(sqliteDb, pathConstraintsFromQuery)
 			if err != nil {
 				return nil, fmt.Errorf("checking source path constraints: %w", err)