SA4023 staticcheck fixes #4055
golangci-lint.yml
on: pull_request
Matrix: lint
lint_mergeable
0s
Annotations
6 errors and 6 warnings
lint (windows-latest):
ee/desktop/runner/runner.go#L198
SA4023: this comparison is always true (staticcheck)
|
lint (windows-latest):
ee/desktop/runner/runner.go#L197
SA4023(related information): the lhs of the comparison is the 2nd return value of this function call (staticcheck)
|
lint (windows-latest):
ee/desktop/runner/runner_windows.go#L64
SA4023(related information): github.com/kolide/launcher/ee/desktop/runner.osversion never returns a nil interface value (staticcheck)
|
lint (windows-latest):
ee/desktop/runner/runner.go#L884
SA4023: this comparison is always true (staticcheck)
|
lint (windows-latest):
ee/desktop/runner/runner.go#L883
SA4023(related information): the lhs of the comparison is the 2nd return value of this function call (staticcheck)
|
lint (windows-latest)
issues found
|
lint (ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-go@v3, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
lint (ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
lint (macos-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-go@v3, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
lint (macos-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
lint (windows-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-go@v3, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
lint (windows-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|