Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support argon2 #482

Closed
wants to merge 2 commits into from
Closed

Conversation

1673beta
Copy link
Contributor

@1673beta 1673beta commented Aug 1, 2024

What

  • パスワードのハッシュ関数をbcryptからArgon2に
    • argon2.hash関数には引数を取らなくてもsaltを生成する機能があります
  • パスワードのハッシュ、比較などの共通した処理を@/misc/password.tsに移動

Why

solve #481

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

1673beta and others added 2 commits August 1, 2024 14:50
* wip: argon2

* feat: argon2 support

* remove unused import

* Update CHANGELOG
@1673beta 1673beta changed the title Argon2 feat: support argon2 Aug 1, 2024
@1673beta
Copy link
Contributor Author

1673beta commented Aug 1, 2024

追記: 一度ログアウトしてからログインし直すとパスワードのハッシュがbcryptからArgon2idで生成されたものに置き換わります

@1673beta 1673beta marked this pull request as draft August 1, 2024 15:05
@1673beta 1673beta closed this Aug 4, 2024
@1673beta 1673beta deleted the argon2 branch August 4, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant