Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

비로그인 사용자의 특정 페이지 헤더를 다르게 표시 #397

Merged
merged 3 commits into from Dec 4, 2023
Merged

Conversation

SWREI
Copy link
Contributor

@SWREI SWREI commented Dec 1, 2023

What

/channels, /play와 같이 비로그인 방문 가능 페이지의 비로그인 사용자 기준 헤더가 다르게 보이도록 표시합니다.

Why

비로그인 사용자가 현재 "관리중" 같은 탭에 들어가면 "로그인이 필요합니다" 대신 오류가 발생하고 있기에, 차라리 해당 탭들 및 + 버튼을 아예 표시하지 않도록 변경했습니다.

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

just for not show any error message when exploring
@SWREI SWREI changed the title fix: change header for not logged in users 비로그인 사용자의 채널 페이지 헤더를 다르게 표시 Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0bdab5a) 78.92% compared to head (34387b2) 78.92%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #397   +/-   ##
========================================
  Coverage    78.92%   78.92%           
========================================
  Files          184      184           
  Lines        26169    26169           
  Branches       522      522           
========================================
  Hits         20655    20655           
  Misses        5514     5514           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SWREI
Copy link
Contributor Author

SWREI commented Dec 1, 2023

PC 기준으로는 채널 밖에 보이지 않지만 갤러리나 페이지 등에도 적용되는 사안인 듯합니다! 이에 대한 추가 패치가 있어야 될 것 같아요.

@SWREI SWREI marked this pull request as draft December 1, 2023 09:00
@SWREI SWREI changed the title 비로그인 사용자의 채널 페이지 헤더를 다르게 표시 비로그인 사용자의 특정 페이지 헤더를 다르게 표시 Dec 1, 2023
@SWREI SWREI marked this pull request as ready for review December 1, 2023 09:56
@noridev noridev self-requested a review December 4, 2023 07:02
@noridev noridev merged commit 9c5f319 into kokonect-link:develop Dec 4, 2023
10 of 15 checks passed
@SWREI SWREI deleted the patch-1 branch December 4, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants