Skip to content

Commit

Permalink
fix(sw): 유니코드 이모지로 리액션한 경우에도 리액션 알림에 :가 표시됨
Browse files Browse the repository at this point in the history
  • Loading branch information
noridev committed Jun 4, 2024
1 parent a4f85fd commit b84bda3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG_CHERRYPICK.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ Misskey의 전체 변경 사항을 확인하려면, [CHANGELOG.md#2024xx](CHANGE
### Client
- Fix: 타임라인 노트의 리액션 뷰어에 리모트 서버의 커스텀 이모지가 표시되지 않음

### Server
- Fix: 유니코드 이모지로 리액션한 경우에도 리액션 알림에 `:`가 표시됨

---

## 4.8.0
Expand Down
2 changes: 1 addition & 1 deletion packages/sw/src/scripts/create-notification.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ async function composeNotification(data: PushNotificationDataMap[keyof PushNotif
const tag = `reaction:${data.body.note.id}`;
return [t('_notification.youGotReact', { name: getUserName(data.body.user) }), {
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
body: `:${ reaction }:` + '\n' + data.body.note.text ?? '',
body: (reaction.startsWith(':') ? `:${ reaction }:` : `${ reaction }`) + '\n' + data.body.note.text ?? '',
icon: data.body.user.avatarUrl,
tag,
badge,
Expand Down

0 comments on commit b84bda3

Please sign in to comment.