Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submdspan bring in line with latest C++ draft (hidden friends) #283

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Submdspan bring in line with latest C++ draft (hidden friends) #283

merged 3 commits into from
Oct 19, 2023

Conversation

crtrott
Copy link
Member

@crtrott crtrott commented Oct 16, 2023

  • Make submdspan_mapping hidden friends.
  • Take them out of the Proposed namespace since it is merged into draft.

@crtrott crtrott changed the title Submdspan updates Submdspan bring in line with latest C++ draft (hidden friends) Oct 18, 2023
mhoemmen
mhoemmen approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@mhoemmen mhoemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crtrott and I discussed these changes offline. They bring the implementation in line with the spec.

dalg24
dalg24 approved these changes Oct 19, 2023
View reviewed changes
include/experimental/__p2630_bits/submdspan_mapping.hpp Outdated Show resolved Hide resolved
include/experimental/__p0009_bits/layout_left.hpp Outdated Show resolved Hide resolved
include/experimental/__p0009_bits/layout_right.hpp Outdated Show resolved Hide resolved
include/experimental/__p0009_bits/layout_stride.hpp Outdated Show resolved Hide resolved
@crtrott crtrott merged commit 33a0b93 into kokkos:stable Oct 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@mhoemmen mhoemmen mhoemmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crtrott @dalg24 @mhoemmen