Merge pull request #345 from masterleinad/gh_workflow_msvc

Test with Windows and MSVC

.github/workflows/cmake-windows.yml

@@ -0,0 +1,47 @@
+name: CMake Windows
+
+on:
+  push:
+  pull_request:
+
+concurrency:
+  group: ${ {github.event_name }}-${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{github.event_name == 'pull_request'}}
+
+permissions: read-all
+
+jobs:
+  test_cmake-windows:
+    name: MSVC C++-17
+    runs-on: windows-2022
+
+    steps:
+    - uses: ilammy/msvc-dev-cmd@v1
+
+    - name: Create Build Environment
+      run: cmake -E make_directory ${{github.workspace}}/mdspan-build
+
+    - name: Check Out
+      uses: actions/checkout@v2
+      with:
+        path: ${{github.workspace}}/mdspan-src
+
+    - name: Configure CMake
+      shell: bash
+      working-directory: ${{github.workspace}}/mdspan-build
+      run: cmake -DCMAKE_CXX_FLAGS=-EHsc $GITHUB_WORKSPACE/mdspan-src -DMDSPAN_CXX_STANDARD=17 -DCMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/mdspan-install -DMDSPAN_ENABLE_TESTS=ON -DMDSPAN_ENABLE_EXAMPLES=ON 
+
+    - name: Build
+      shell: bash
+      working-directory: ${{github.workspace}}/mdspan-build
+      run: cmake --build . --parallel 4 --config Debug
+
+    - name: Test
+      working-directory: ${{github.workspace}}/mdspan-build
+      shell: bash
+      run: ctest --output-on-failure --
+
+    - name: Install
+      shell: bash
+      working-directory: ${{github.workspace}}/mdspan-build
+      run: cmake --build . --target install

examples/aligned_accessor/aligned_accessor.cpp

@@ -28,6 +28,7 @@
 #include <iostream>
 #include <memory>
 #include <type_traits>
+#include <string> // stoi
 
 // mfh 2022/08/08: This is based on my comment on RAPIDS RAFT issue 725:
 // https://github.com/rapidsai/raft/pull/725#discussion_r937991701

examples/restrict_accessor/restrict_accessor.cpp

@@ -20,6 +20,7 @@
 #include <iostream>
 #include <type_traits>
 #include <vector>
+#include <string> // stoi
 
 // mfh 2022/08/04: This is based on my comments on reference mdspan
 // implementation issue https://github.com/kokkos/mdspan/issues/169.

tests/CMakeLists.txt

@@ -62,6 +62,8 @@ else()
   )
 endif()
 
+# FIXME_MSVC
+if(NOT CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
 mdspan_add_test(
   test_precondition_checks_can_be_disabled
   SOURCE test_alternate_precondition_violation_handler.cpp
@@ -76,6 +78,7 @@ set_tests_properties(
 PROPERTIES
   PASS_REGULAR_EXPRESSION "Failure.*Expected.*throws an exception of type std::logic_error.*Actual.*it throws nothing"
 )
+endif()
 
 if(NOT MDSPAN_ENABLE_CUDA AND NOT MDSPAN_ENABLE_HIP AND NOT MDSPAN_ENABLE_SYCL)
 mdspan_add_test(test_alternate_precondition_violation_handler ENABLE_PRECONDITIONS)