Add irecv wrapper in KokkosComm namespace #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dssgabriel
previously approved these changes
Jun 6, 2024
|
I'd like this too for #53. |
aprokop
approved these changes
Jun 11, 2024
|
Also needs |
7 tasks
dssgabriel
reviewed
Jun 12, 2024
src/KokkosComm.hpp
Outdated
| @@ -33,6 +34,11 @@ Req isend(const ExecSpace &space, const SendView &sv, int dest, int tag, MPI_Com | |||
| return Impl::isend<SendMode>(space, sv, dest, tag, comm); | |||
| } | |||
|
|
|||
| template <KokkosView RecvView> | |||
| void irecv(RecvView &sv, int src, int tag, MPI_Comm comm, MPI_Request req) { | |||
There was a problem hiding this comment.
Why use sv for the receiving view? I think it was previously clearer with rv instead.
There was a problem hiding this comment.
I was trying to more closely match the recv wrapper in the file:
template <KokkosExecutionSpace ExecSpace, KokkosView RecvView>
void recv(const ExecSpace &space, RecvView &sv, int src, int tag, MPI_Comm comm) {
return Impl::recv(space, sv, src, tag, comm);
}
I agree it is clearer, I can change it back.
There was a problem hiding this comment.
I think you can change the recv wrapper to RecvView &rv as well then 👍
|
As the |
cwpearson
approved these changes
Jun 12, 2024
| template <CommMode SendMode = CommMode::Default, KokkosExecutionSpace ExecSpace, KokkosView SendView> | ||
| void send(const ExecSpace &space, const SendView &sv, int dest, int tag, MPI_Comm comm) { | ||
| return Impl::send<SendMode>(space, sv, dest, tag, comm); | ||
| } | ||
|
|
||
| template <KokkosExecutionSpace ExecSpace, KokkosView RecvView> | ||
| void recv(const ExecSpace &space, RecvView &sv, int src, int tag, MPI_Comm comm) { | ||
| return Impl::recv(space, sv, src, tag, comm); | ||
| void recv(const ExecSpace &space, RecvView &rv, int src, int tag, MPI_Comm comm) { |
aprokop
reviewed
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, irecv is only available in the Impl namespace.