Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OSU Latency microbenchmarks for send/recv and isend/irecv #101

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Add OSU Latency microbenchmarks for send/recv and isend/irecv #101

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eeb4aec
add osu latency tests
nicoleavans Jun 26, 2024
a0971df
remove comment, reduce testing range
nicoleavans Jun 26, 2024
1c91516
newline
nicoleavans Jun 26, 2024
002a1f0
add view labels
nicoleavans Jun 26, 2024
9f51209
add view labels
nicoleavans Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions perf_tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ unset(BENCHMARK_ENABLE_TESTING)
add_executable(perf_test-main test_main.cpp
test_sendrecv.cpp
test_2dhalo.cpp
test_osu_latency_sendrecv.cpp
test_osu_latency_isendirecv.cpp
)
if(KOKKOSCOMM_ENABLE_TESTS)
kokkoscomm_add_cxx_flags(TARGET perf_test-main)
Expand Down
94 changes: 94 additions & 0 deletions perf_tests/test_osu_latency_isendirecv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
//@HEADER
// ************************************************************************
//
// Kokkos v. 4.0
// Copyright (2022) National Technology & Engineering
// Solutions of Sandia, LLC (NTESS).
//
// Under the terms of Contract DE-NA0003525 with NTESS,
// the U.S. Government retains certain rights in this software.
//
// Part of Kokkos, under the Apache License v2.0 with LLVM Exceptions.
// See https://kokkos.org/LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//@HEADER

// Adapted from the OSU Benchmarks
// Copyright (c) 2002-2024 the Network-Based Computing Laboratory
// (NBCL), The Ohio State University.

#include "test_utils.hpp"
#include "KokkosComm.hpp"

template <typename Space, typename View>
void osu_latency_Kokkos_Comm_isendirecv(benchmark::State &, MPI_Comm comm, const Space &space, int rank,
const View &v) {
if (rank == 0) {
KokkosComm::Req sendreq = KokkosComm::isend(space, v, 1, 1, comm);
sendreq.wait();
} else if (rank == 1) {
KokkosComm::Req recvreq = KokkosComm::irecv(v, 0, 1, comm);
nicoleavans marked this conversation as resolved.
Show resolved Hide resolved
recvreq.wait();
}
}

template <typename View>
void osu_latency_MPI_isendirecv(benchmark::State &, MPI_Comm comm, int rank, const View &v) {
MPI_Barrier(comm);
MPI_Request sendreq, recvreq;
if (rank == 0) {
MPI_Irecv(v.data(), v.size(), KokkosComm::Impl::mpi_type<typename View::value_type>(), 1, 0, comm, &recvreq);
MPI_Wait(&recvreq, MPI_STATUS_IGNORE);
} else if (rank == 1) {
MPI_Isend(v.data(), v.size(), KokkosComm::Impl::mpi_type<typename View::value_type>(), 0, 0, comm, &sendreq);
MPI_Wait(&sendreq, MPI_STATUS_IGNORE);
}
}

void benchmark_osu_latency_KokkosComm_isendirecv(benchmark::State &state) {
int rank, size;
MPI_Comm_rank(MPI_COMM_WORLD, &rank);
MPI_Comm_size(MPI_COMM_WORLD, &size);
if (size != 2) {
state.SkipWithError("benchmark_osu_latency_KokkosComm needs exactly 2 ranks");
}

auto space = Kokkos::DefaultExecutionSpace();
using view_type = Kokkos::View<char *>;
view_type a("", state.range(0));
nicoleavans marked this conversation as resolved.
Show resolved Hide resolved

while (state.KeepRunning()) {
do_iteration(state, MPI_COMM_WORLD, osu_latency_Kokkos_Comm_isendirecv<Kokkos::DefaultExecutionSpace, view_type>,
space, rank, a);
}
state.counters["bytes"] = a.size() * 2;
}

void benchmark_osu_latency_MPI_isendirecv(benchmark::State &state) {
int rank, size;
MPI_Comm_rank(MPI_COMM_WORLD, &rank);
MPI_Comm_size(MPI_COMM_WORLD, &size);
if (size != 2) {
state.SkipWithError("benchmark_osu_latency_MPI needs exactly 2 ranks");
}

using view_type = Kokkos::View<char *>;
view_type a("", state.range(0));
nicoleavans marked this conversation as resolved.
Show resolved Hide resolved

while (state.KeepRunning()) {
do_iteration(state, MPI_COMM_WORLD, osu_latency_MPI_isendirecv<view_type>, rank, a);
}
state.counters["bytes"] = a.size() * 2;
}

BENCHMARK(benchmark_osu_latency_KokkosComm_isendirecv)
->UseManualTime()
->Unit(benchmark::kMicrosecond)
->RangeMultiplier(2)
->Range(1, 1000);
BENCHMARK(benchmark_osu_latency_MPI_isendirecv)
->UseManualTime()
->Unit(benchmark::kMicrosecond)
->RangeMultiplier(2)
->Range(1, 1000);
89 changes: 89 additions & 0 deletions perf_tests/test_osu_latency_sendrecv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
//@HEADER
// ************************************************************************
//
// Kokkos v. 4.0
// Copyright (2022) National Technology & Engineering
// Solutions of Sandia, LLC (NTESS).
//
// Under the terms of Contract DE-NA0003525 with NTESS,
// the U.S. Government retains certain rights in this software.
//
// Part of Kokkos, under the Apache License v2.0 with LLVM Exceptions.
// See https://kokkos.org/LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//@HEADER

// Adapted from the OSU Benchmarks
// Copyright (c) 2002-2024 the Network-Based Computing Laboratory
// (NBCL), The Ohio State University.

#include "test_utils.hpp"
#include "KokkosComm.hpp"

template <typename Space, typename View>
void osu_latency_Kokkos_Comm_sendrecv(benchmark::State &, MPI_Comm comm, const Space &space, int rank, const View &v) {
if (rank == 0) {
KokkosComm::send(space, v, 1, 0, comm);
} else if (rank == 1) {
KokkosComm::recv(space, v, 0, 0, comm);
}
}

template <typename View>
void osu_latency_MPI_sendrecv(benchmark::State &, MPI_Comm comm, int rank, const View &v) {
MPI_Barrier(comm);
if (rank == 0) {
MPI_Recv(v.data(), v.size(), KokkosComm::Impl::mpi_type<typename View::value_type>(), 1, 0, comm,
MPI_STATUS_IGNORE);
} else if (rank == 1) {
MPI_Send(v.data(), v.size(), KokkosComm::Impl::mpi_type<typename View::value_type>(), 0, 0, comm);
}
}

void benchmark_osu_latency_KokkosComm_sendrecv(benchmark::State &state) {
int rank, size;
MPI_Comm_rank(MPI_COMM_WORLD, &rank);
MPI_Comm_size(MPI_COMM_WORLD, &size);
if (size != 2) {
state.SkipWithError("benchmark_osu_latency_KokkosComm needs exactly 2 ranks");
}

auto space = Kokkos::DefaultExecutionSpace();
using view_type = Kokkos::View<char *>;
view_type a("", state.range(0));

while (state.KeepRunning()) {
do_iteration(state, MPI_COMM_WORLD, osu_latency_Kokkos_Comm_sendrecv<Kokkos::DefaultExecutionSpace, view_type>,
space, rank, a);
}
state.counters["bytes"] = a.size() * 2;
}

void benchmark_osu_latency_MPI_sendrecv(benchmark::State &state) {
int rank, size;
MPI_Comm_rank(MPI_COMM_WORLD, &rank);
MPI_Comm_size(MPI_COMM_WORLD, &size);
if (size != 2) {
state.SkipWithError("benchmark_osu_latency_MPI needs exactly 2 ranks");
}

using view_type = Kokkos::View<char *>;
view_type a("", state.range(0));

while (state.KeepRunning()) {
do_iteration(state, MPI_COMM_WORLD, osu_latency_MPI_sendrecv<view_type>, rank, a);
}
state.counters["bytes"] = a.size() * 2;
}

BENCHMARK(benchmark_osu_latency_KokkosComm_sendrecv)
->UseManualTime()
->Unit(benchmark::kMicrosecond)
->RangeMultiplier(2)
->Range(1, 1000);
BENCHMARK(benchmark_osu_latency_MPI_sendrecv)
->UseManualTime()
->Unit(benchmark::kMicrosecond)
->RangeMultiplier(2)
->Range(1, 1000);
nicoleavans marked this conversation as resolved.
Show resolved Hide resolved
Loading