Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few updates to the standard library for
maybe
. Open to feedback / suggestions.I've improved the error location for the
unjust
function. I also renamedunjust2
tounjust
, since none of the other functions incore/maybe2
use the2
qualifier, and we have static overloading which can resolve this most of the time.I then also added an
expect
function which expects an explicit error message as a second parameter.This mimics the naming of this function in Rust's Option type, but I'm open to other names.
If we go with Rust's naming for this it might be good to look at also changing
unjust
tounwrap
- maybe with a deprecation notice on the old definition due to it's wide use. Haskell usesfromMaybe
, Swift uses a postfix!
andunsafelyUnwrap
for no runtime checks in non-debug builds.