-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always parse query string, on the main request or on sub-requests #693
Conversation
Initial request will have the global $_GET re-applied in the `factory()` method.
Thanks for the swift fix! It looks good to me! I could probably try to work on a test for that a bit later today and if I succeed will PR your branch. |
Test query params are parsed correctly in both initial and subrequests
hello, Thanks to all, what are the main differences with 3.3.5? EDIT here it is sorry xD https://github.com/kohana/kohana/releases I will test later, regards |
Thanks @enov |
@enov the release is missing, the packed version with the core in it I mean. Also the modules, I have used the ones packed for 3.3.5. I have updated the release and added the ZIP file. I hope I have done this correctly. |
ok,have tested and all seems ok ;) |
Thanks @neo22s |
Initial request will have the global $_GET re-applied in the
factory()
method.
Related to #627 (comment)
cc @hkdobrev
@acoulton could you please advise how to add a test case for this.