Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added convenience methods for request type checking #417

Open
wants to merge 2 commits into
base: 3.4/develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions classes/Kohana/Request.php
Original file line number Diff line number Diff line change
Expand Up @@ -1328,4 +1328,72 @@ public function post($key = NULL, $value = NULL)
return $this;
}

/**
* Check to see if the current request is a POST request.
*
* @return bool Whether the request is a POST request or not.
*/
public function is_post()
{
if ($this->method() === HTTP_Request::POST)
{
return TRUE;
}
else
{
return FALSE;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return ($this->method() === HTTP_Request::POST)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return ($this->_method === HTTP_Request::POST)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@birkir yep, you're right, but canonical

return (HTTP_Request::POST === $this->_method)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the parentheses needed here?

Edit: Nevermind, I see that this is the style follow through the rest of the file.

}

/**
* Check to see if the current request is a GET request.
*
* @return bool Whether the request is a GET request or not.
*/
public function is_get()
{
if ($this->method() === HTTP_Request::GET)
{
return TRUE;
}
else
{
return FALSE;
}
}

/**
* Check to see if the current request is a PUT request.
*
* @return bool Whether the request is a PUT request or not.
*/
public function is_put()
{
if ($this->method() === HTTP_Request::PUT)
{
return TRUE;
}
else
{
return FALSE;
}
}

/**
* Check to see if the current request is a DELETE request.
*
* @return bool Whether the request is a DELETE request or not.
*/
public function is_delete()
{
if ($this->method() === HTTP_Request::DELETE)
{
return TRUE;
}
else
{
return FALSE;
}
}

} // End Request