Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3/Kodi 19 compatibility #76

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Python3/Kodi 19 compatibility #76

merged 1 commit into from
Jan 7, 2022

Conversation

peci1
Copy link

@peci1 peci1 commented Jan 23, 2021

Potreboval jsem zprovoznit ivysilani na Kodi 19, a k tomu bylo potreba updatovat tenhle plugin. Vic funkcionality jsem netestoval.

Pokud jsem spravne rozumel poznamkam k upgrade na Kodi 19/Python 3, tak addony maji mit zvlast branch pro Kodi 18- a zvlast pro Kodi 19+. Ale nevim, jestli to neni jen pozadavek oficialniho repository. Pokud by to tak bylo, tak by bylo potreba tenhle PR zavrit a misto toho z nej vytvorit novou branch. Nebo nevim, jak se s Kodi 19 chce vyporadat CZ-SK repo.

Mozna resi #75.

Basically just ran 2to3
@peci1 peci1 mentioned this pull request Jan 23, 2021
@peci1
Copy link
Author

peci1 commented Jan 23, 2021

Zavisi na kodi-czsk/script.module.demjson#1 .

@brozikcz
Copy link
Contributor

Netusim, jak to ma byt, ale rekl bych, ze je potreba nejak upravit? deploy script, aby byly dostupne obe verze, jak pro kodi <= 18 a kodi 19. Zaroven asi i ty dve vetve, abychom mohli mit dostupne obe, protoze uz vidim ruzne cinske krabice, ktere nepujdou upgradovat na kodi 19 a nasince, jak rvou, ze jim nejaky plugin nefunguje...
Ale to je jen teorie, chtelo by to se nekde inspirovat :)

@peci1
Copy link
Author

peci1 commented Jan 23, 2021

Nevim, jaky je vztah kodi-czsk a xbmc-kodi-cz-sk, ale tam pisou tohle: https://www.xbmc-kodi.cz/prispevek-repozitar-xbmc-kodi-cz-sk-navrhy-doplnku?pid=95534#pid95534 .

@brozikcz
Copy link
Contributor

Nejjednodussi bude, kdyz ten pull request presunes do jejich forku https://github.com/xbmc-kodi-cz/script.module.stream.resolver

Nevim, jestli nekdo bude nejak resit upravu tohoto repa (kodi-czsk) na python 3. @jose1711

@peci1
Copy link
Author

peci1 commented Feb 21, 2021

Ok, portnul jsem vsechny tri PR na xbmc-kodi-cz. Takze kodi-czsk repo uz je v nejakem utlumu? Nebo chcete jet dal, ale jen do verze Leia?

@lzoubek
Copy link
Member

lzoubek commented Feb 22, 2021

Porad nemam jasno jak se k tomu postavit,

Kdyz to mergneme do masteru a vydame verzi kompatibilni s kodi 19, nerozbijeme verze 18?
Kdyz udelame vse v jine branch, budou pak muset useri instalovat nove repo.

@brozikcz
Copy link
Contributor

brozikcz commented Feb 22, 2021

Tak jako tak, to nekomu rozbijeme / prestane to nekomu fungovat. Otazka je, jestli udelat nove repo pro 19+ a nebo udelat nove repo pro starsi verze.
Asi se mi libi vice predstava, ze repo bude pokracovat s python3.

To, ze se rozhoduje do jakeho repa pridat dany addon podle verze xbmc.python mi prijde jako dobry napad. Chtel jsem upravit generovani repositare, ale pak jsem se na to vybodl, protoze stejne netusim, kde a jak to bezi.
Pripadny backport zmen pro python2 by se resil, az by to bylo potreba...

@brozikcz brozikcz merged commit 4429bb2 into kodi-czsk:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants