Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑 max on XCM results in loss of funds #9129

Merged
merged 2 commits into from
Jan 25, 2024
Merged

🚑 max on XCM results in loss of funds #9129

merged 2 commits into from
Jan 25, 2024

Conversation

vikiival
Copy link
Member

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • 🚑 Hotfit

Context

as with convo with @dudo50

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@vikiival vikiival requested a review from a team as a code owner January 24, 2024 18:14
@vikiival vikiival requested review from preschian and Jarsen136 and removed request for a team January 24, 2024 18:14
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2583015
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65b294ef689a1f000875755f
😎 Deploy Preview https://deploy-preview-9129--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jan 24, 2024
Copy link
Contributor

reviewpad bot commented Jan 24, 2024

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link
Contributor

reviewpad bot commented Jan 24, 2024

AI-Generated Summary: This pull request addresses an issue to prevent the loss of funds in the file Teleport.vue within the teleport component. In the code, the handleMaxClick function has been disabled and renamed to _handleMaxClick. Correspondingly, the NeoButton component, which triggers this function on clicking, has been commented out. The button was previously used to set the amount.value to myBalance.value.

@Jarsen136
Copy link
Contributor

There is a left one

image

@vikiival
Copy link
Member Author

There is a left one

Faaak forgot to push 🥲

Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codeclimate bot commented Jan 25, 2024

Code Climate has analyzed commit 2583015 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 0e16eb1 into main Jan 25, 2024
14 of 15 checks passed
@vikiival vikiival deleted the fix/disable-max branch January 25, 2024 17:06
@dudo50
Copy link
Contributor

dudo50 commented Jan 30, 2024

Issue is now in Parity's Pipeline to fix:
paritytech/polkadot-sdk#3050 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants