Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Item Edit: Limit Name and Image Update #11200

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Dec 1, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs QA check

  • @kodadot/qa-guild please review

Context

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image image

@Jarsen136 Jarsen136 requested a review from a team as a code owner December 1, 2024 14:07
@Jarsen136 Jarsen136 requested review from preschian and hassnian and removed request for a team December 1, 2024 14:07
Copy link

netlify bot commented Dec 1, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 51b7484
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/674ec6badc89ca000825a569
😎 Deploy Preview https://deploy-preview-11200--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hassnian
hassnian previously approved these changes Dec 2, 2024
@hassnian hassnian dismissed their stale review December 2, 2024 06:36

sugesstion

Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add a revert/undo changes button

locales/en.json Outdated Show resolved Hide resolved
components/common/EditNftModal.vue Outdated Show resolved Hide resolved
@Jarsen136
Copy link
Contributor Author

I would also add a revert/undo changes button

Updated

Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! LGTM

small change

locales/en.json Show resolved Hide resolved
@hassnian hassnian added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Dec 3, 2024
Copy link

sonarcloud bot commented Dec 3, 2024

@vikiival vikiival added this pull request to the merge queue Dec 4, 2024
Merged via the queue into kodadot:main with commit eaad18c Dec 4, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Item Edit: Limit Name and Image Update
4 participants