Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display Swap in Item View & Profile View #11182

Merged
merged 25 commits into from
Nov 27, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Nov 20, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

@exezbcz do we have. a design for the swap modal, item view table and profile table?

Screenshot 📸

  • My fix has changed something on UI;

Swap modal

Item view

image

Profile view

CleanShot 2024-11-23 at 07 51 43@2x

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit cf5679d
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/674705244019620008a315f2
😎 Deploy Preview https://deploy-preview-11182--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian marked this pull request as ready for review November 26, 2024 11:03
@hassnian hassnian requested a review from a team as a code owner November 26, 2024 11:03
@hassnian hassnian requested review from vikiival and Jarsen136 and removed request for a team November 26, 2024 11:03
@vikiival
Copy link
Member

Seem you have some conflicts

@hassnian
Copy link
Contributor Author

Seem you have some conflicts

resolved

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

queries/subsquid/general/swapsList.graphql Show resolved Hide resolved
@vikiival vikiival enabled auto-merge November 27, 2024 11:40
@vikiival vikiival added this pull request to the merge queue Nov 27, 2024
Merged via the queue into kodadot:main with commit 84aea3d Nov 27, 2024
14 of 17 checks passed
Copy link

sonarcloud bot commented Nov 27, 2024

@exezbcz
Copy link
Member

exezbcz commented Dec 4, 2024

@exezbcz do we have. a design for the swap modal, item view table and profile table?

seems like you manage to do it on your own, good job sir

in the swap modal i would only add: your send, you get

so its more clear which nft is actually yours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants