Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 action list price is_null #11176

Merged
merged 6 commits into from
Nov 24, 2024
Merged

🔧 action list price is_null #11176

merged 6 commits into from
Nov 24, 2024

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Nov 12, 2024

note: pain to debug

@roiLeo roiLeo requested a review from a team as a code owner November 12, 2024 10:52
@roiLeo roiLeo requested review from preschian and hassnian and removed request for a team November 12, 2024 10:52
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f1bf71f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/67409b53ab964f0007d3b242
😎 Deploy Preview https://deploy-preview-11176--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian
Copy link
Contributor

@roiLeo it's working for some NFTs and for some it's still not

CleanShot.2024-11-13.at.12.29.15.mp4

@roiLeo
Copy link
Contributor Author

roiLeo commented Nov 13, 2024

@roiLeo it's working for some NFTs and for some it's still not

can't reproduce, could you share your address?

edit: nvm found a case with infinite loop 😨

@hassnian hassnian added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Nov 15, 2024
@vikiival vikiival mentioned this pull request Nov 20, 2024
5 tasks
@vikiival vikiival requested a review from Jarsen136 November 22, 2024 11:15
Copy link

sonarcloud bot commented Nov 22, 2024

@vikiival vikiival added this pull request to the merge queue Nov 24, 2024
Merged via the queue into kodadot:main with commit 516e3e2 Nov 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-changes-requested-🤞 PR is almost good to go, just some fine tunning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore Items Listing Not working
5 participants