Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Meter component #500

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: Meter component #500

wants to merge 5 commits into from

Conversation

Shubhdeep12
Copy link

@Shubhdeep12 Shubhdeep12 commented Oct 16, 2024 •
edited by jer3m01
Loading

closes #316

  • To create Meter component
  • To add examples for Meter
  • To add docs for Meter
  • Tests for Meter
  • To extend Meter in Progress bar component

Description

  • The Meter component is built on the same foundation as the Progress, sharing much of the same structure and logic.
  • Key differences between the Meter and Progress bar components:
    • The Meter component will always display a determinate value.
    • Unlike the Progress, the Meter does not have loading or complete states, as it only reflects a specific, static value.

@netlify Netlify
Copy link

netlify bot commented Oct 16, 2024 •
edited
Loading

👷 Deploy request for kobalte pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ac42c99

@Shubhdeep12
Copy link
Author

cc @jer3m01

@jer3m01
Copy link
Member

jer3m01 commented Oct 17, 2024

Since Meter is so similar to Progress it would be better to make one of them extend the other.

Like Progress returns a Meter with extra attributes (and make Progress much smaller with mostly re-exports from Meter).

@Shubhdeep12
Copy link
Author

Yeah makes sense.
Let me update it.
Thanks for the review.

@Shubhdeep12
Copy link
Author

Hi @jer3m01 can you please review now.

Made Meter Component Generic and Progress bar now Extends Meter Component.

jer3m01
jer3m01 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@jer3m01 jer3m01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks for the PR and changes! Will merge soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jer3m01 jer3m01 jer3m01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] Meter
2 participants
@Shubhdeep12 @jer3m01