Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL2_image and SDL2_ttf Toolchain fix #2

Open
wants to merge 2 commits into
base: knulli-main
Choose a base branch
from
Open

SDL2_image and SDL2_ttf Toolchain fix #2

wants to merge 2 commits into from

Conversation

bremedios
Copy link

Fixes an issue where programs using the toolchain to compile against the SDL2_image and SDL2_ttf images will fail if they are using CMAKE.

SDL2_image

  • Fix that is already included in the SDL2 build script was added to the SDL2_image

SDL2_ttf

  • Fix that is already included in the SDL2 build script was added to the SDL2_image
  • Manually fixed _sdl2ttf_extra_static_libraries to use -lfreetype and -lharfbuzz

This is a fix for the toolchain not working for compiling programs
80721b7 
that use SDL_image or SDL_ttf and are using the CMAKE build system.

A relocation script was not required after these changes at least
when working against SDL2, SDL2_image and SDL2_ttf.

SDL2_image
    - Copied cmake fix from SDL2 into SDL2_image.
    - Using the toolchain works for static and shared linkage.

SDL2_ttf
    - Same fix as SDL2_image
    - This library also has a bad extra static libs setup where
      it contains more than just static libraries.  REGEX alone
      was not sufficient to resolve, replaced the extra libs with
      the necessary libraries.
@bremedios
Copy link
Author

bremedios commented Nov 11, 2024 •
edited
Loading

Notes / Open Issues:

  • This still builds images for the h700
  • The toolchain is not fixed for the A133, but appears to be fixed for the h700.
  • This does not build for the atm7039 (Original RG35XX)

This has been compiled against the h700

  • Build compiles
  • Toolchain works for cross compilation of program using SDL2, SDL2_image and SDL2_ttf

This has been compiled against the A133

  • Build compiles
  • Toolchain DOES NOT WORK for cross compilation of program using SDL2, SDL2_image and SDL2_ttf**

@bremedios bremedios marked this pull request as draft November 11, 2024 17:29
@bremedios bremedios marked this pull request as ready for review November 12, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bremedios