This repository has been archived by the owner on Feb 3, 2020. It is now read-only.
fix: type-safety of action creators #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 39 39
Branches 7 7
=====================================
Hits 39 39
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #27 and #28 - both issues are related and are fixed by the same piece of code.
I am unable to add tests for the fixed behaviour as the code would simply fail to compile.
Now that
createAction('type')is the same ascreateAction<void>('type')instead ofcreateAction<{}>('type')I updated the README to suggest the shorter form as preferable.