Pull Request for Issue #191 #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackUpFromSmall call to the outer loop. This should fix kni-labs#191
|
Looks good to me. Can anyone else confirm? |
|
It would be very good if someone else could confirm, since it is the only thing preventing multiple times per site usage. I am using it with the above changes on my site and did not encounter any issues. |
|
ping @dbox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #191.
Problem
The backUpFromSmall function gets unnecessarily often called because the if condition is always true.
The code with the count variable and if condition was introduced in 1a55eb4 . The count variable was then shadowed in b179044 with a parameter. The original count variable was then removed in b615b21, since it was not used anymore.
According to the jquery docs the second argument of each is the value and not the count.
Summary of Changes
Rename the second argument of each from count to value and move the backUpFromSmall call to the outer loop.