Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

each(function(index, count)... second parameter is not count but element #191

Open
tomaszrondio opened this issue Oct 20, 2016 · 2 comments

Comments

@tomaszrondio
Copy link

// get buttons in reverse order and loop through each
$(buttons.get().reverse()).each(function(index, count) {

this is always true because count is not a number so backUpFromSmall() is fired every time
if (!--count) backUpFromSmall();

@dbox
Copy link
Contributor

dbox commented Jan 16, 2017

Hey @tomaszrondio. Thanks! Care to offer a PR to fix?

@tomaszrondio
Copy link
Author

I would if I could :) I am not sure what would be a fix here that is why I opened an issue instead of PR.

bonzani added a commit to bonzani/rrssb that referenced this issue Jul 28, 2017
…ackUpFromSmall call to the outer loop.

This should fix kni-labs#191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants